karpenter 0.32 #112
Merged
karpenter 0.32 #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thepoppingone
commented
Nov 6, 2023
thepoppingone
commented
- resolve ip6 conflict
- Refactor karpenter
- Remove unused vars
- Update flag for count using autoscaling mode
- Add more details for allow CRDs installation first
- Update vars
- Resolve readme conflict
- Patch again to stop duplicate creation of logging policy
- Re apply karpenter module after CRD installed
- Try just use values
- set attribute accessor
- Fix service account missing role arn
- set chart version variable for karpenter
- Use cluster sec group instead of node as its using fargate
- Use 8 cpu
- Try empty string map instead of null object
- Set default tags
- Attach primary cluster sec group as well to nodes on karpenter
- Add outputs
- Use cluster primary sec group
- convert to kubectl
- Remove install crd first var flag
- Test if requirements is the error
- Test no taints and labels
- Fix missing taints and labels key
- Remove taints to test again
- Test provisioneres removal
- Test indent
- Add indent function
- Test removal of quotes
- Add indent
- Add depends on
- Make node templates required var
- remove default observability ns creation as default fargate profile would handle it
- Add kubectl provider
- Add helm provider version
- Add kubernetes provider
- Remove extra provider
- remove provider config
- add providers back
- Add block device mapping customiziation
- Test device block mapping
- add provisioner_name to template
- Add enablePodEni - defaults to true
- Use node label instead of taint
- Set correctly taints
- Fix logic on checking length
- Add secgroupol
- add depends on for helm installation to create ns first
- first draft
- first draft
niroz89
reviewed
Dec 15, 2023
@thepoppingone added tflint ignore. |
* add variable to generalize tags for subnet selector * clean up the code * update default value
uchinda-sph
approved these changes
Feb 19, 2024
niroz89
reviewed
Feb 19, 2024
variables.tf
Outdated
Comment on lines
520
to
522
| default = { | ||
| "Name" = "aft-app-ap-southeast*" | ||
| } |
There was a problem hiding this comment.
Let's remove the default and make it mandatory.
There was a problem hiding this comment.
@niroz89 if we set this as mandatory then tf will fail when assign value to var.karpenter_nodeclasses
https://github.com/SPHTech-Platform/platform-engg-tools/blob/1c325f30697c8ce1abe058e192a1bb760e30486e/envs/prd/github_runner_enterprise/eks_pure_karpenter_cluster/main.tf#L111
* add default value to karpenter_default_subnet_selector_tags * Update variables.tf Co-authored-by: Niro <[email protected]> * update docs --------- Co-authored-by: Niro <[email protected]>
niroz89
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.