Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ovirt,vmware): added serializers so vms with same platform are ma… #223

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

bl4ko
Copy link
Member

@bl4ko bl4ko commented Jul 24, 2024

…pped to same netbox object

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 60.67416% with 35 lines in your changes missing coverage. Please review.

Project coverage is 13.43%. Comparing base (41d39db) to head (6c7caae).
Report is 6 commits behind head on main.

Files Patch % Lines
internal/source/ovirt/ovirt_sync.go 0.00% 21 Missing ⚠️
internal/source/vmware/vmware_sync.go 0.00% 7 Missing ⚠️
internal/utils/dcim.go 91.52% 3 Missing and 2 partials ⚠️
internal/source/dnac/dnac_sync.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
+ Coverage   12.90%   13.43%   +0.52%     
==========================================
  Files          49       50       +1     
  Lines        6624     6678      +54     
==========================================
+ Hits          855      897      +42     
- Misses       5731     5741      +10     
- Partials       38       40       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bl4ko bl4ko force-pushed the feat/platform-serializer branch from f487675 to 6c7caae Compare July 24, 2024 12:04
@bl4ko bl4ko merged commit 6c7caae into main Jul 24, 2024
7 checks passed
@bl4ko bl4ko deleted the feat/platform-serializer branch November 8, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant