Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): reverse lookup should also work on an ip address input wi… #226

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

bl4ko
Copy link
Member

@bl4ko bl4ko commented Jul 31, 2024

…th mask

@bl4ko bl4ko force-pushed the fix/reverse-lookup branch from 960b453 to be22c80 Compare July 31, 2024 11:40
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 13.46%. Comparing base (6c7caae) to head (bb45272).
Report is 3 commits behind head on main.

Files Patch % Lines
internal/source/vmware/vmware_sync.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   13.43%   13.46%   +0.03%     
==========================================
  Files          50       50              
  Lines        6678     6684       +6     
==========================================
+ Hits          897      900       +3     
- Misses       5741     5743       +2     
- Partials       40       41       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bl4ko bl4ko merged commit bb45272 into main Jul 31, 2024
7 checks passed
@bl4ko bl4ko deleted the fix/reverse-lookup branch November 8, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant