Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ovirt): don't stop execution if ip address add fails #250

Merged
merged 4 commits into from
Sep 2, 2024
Merged

Conversation

bl4ko
Copy link
Member

@bl4ko bl4ko commented Aug 29, 2024

No description provided.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 90 lines in your changes missing coverage. Please review.

Project coverage is 12.89%. Comparing base (d35befa) to head (a363298).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
internal/source/vmware/vmware_sync.go 0.00% 27 Missing ⚠️
internal/source/fmc/client/api.go 0.00% 24 Missing ⚠️
internal/source/proxmox/proxmox_sync.go 0.00% 10 Missing ⚠️
internal/source/ovirt/ovirt_sync.go 0.00% 8 Missing ⚠️
internal/source/fmc/fmc_sync.go 0.00% 5 Missing ⚠️
internal/source/fortigate/fortigate_sync.go 0.00% 5 Missing ⚠️
internal/source/ios-xe/iosxe_sync.go 0.00% 5 Missing ⚠️
internal/source/paloalto/paloalto_sync.go 0.00% 5 Missing ⚠️
internal/source/vmware/vmware_init.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
- Coverage   12.95%   12.89%   -0.07%     
==========================================
  Files          52       52              
  Lines        6976     7011      +35     
==========================================
  Hits          904      904              
- Misses       6032     6067      +35     
  Partials       40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bl4ko bl4ko merged commit a363298 into main Sep 2, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant