Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge develop into main #452

Merged
merged 6 commits into from
Jan 31, 2025
Merged

merge develop into main #452

merged 6 commits into from
Jan 31, 2025

Conversation

bl4ko
Copy link
Member

@bl4ko bl4ko commented Jan 31, 2025

No description provided.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 8.01187% with 310 lines in your changes missing coverage. Please review.

Project coverage is 13.79%. Comparing base (8f2ad7b) to head (7d31349).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
internal/netbox/inventory/add_items.go 2.32% 42 Missing ⚠️
internal/source/ios-xe/iosxe_sync.go 0.00% 41 Missing ⚠️
internal/source/fmc/fmc_sync.go 0.00% 33 Missing ⚠️
internal/source/dnac/dnac_init.go 0.00% 29 Missing ⚠️
internal/source/dnac/dnac.go 0.00% 26 Missing ⚠️
internal/source/source.go 0.00% 22 Missing ⚠️
internal/netbox/inventory/init_items.go 0.00% 20 Missing ⚠️
internal/source/fortigate/fortigate_sync.go 0.00% 18 Missing ⚠️
internal/source/vmware/vmware_sync.go 0.00% 15 Missing ⚠️
internal/source/dnac/dnac_sync.go 0.00% 13 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #452      +/-   ##
==========================================
- Coverage   13.84%   13.79%   -0.05%     
==========================================
  Files          57       58       +1     
  Lines       11498    11698     +200     
==========================================
+ Hits         1592     1614      +22     
- Misses       9864    10042     +178     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…source

This must be done to ensure idempotency
@bl4ko bl4ko merged commit 7d31349 into main Jan 31, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant