fix: fix disk size computation #495
Conversation
|
Also have to say this is the problem on the netbox side, since default unit for disks are GiB and not GBs. |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
hello @n-rodriguez, could you push new code as reviewed, can't merge otherwise since ci is failing. |
n-rodriguez
force-pushed
the
fix/disk-computation
branch
from
8009a1f to
4967ea9
Compare
|
It is still old code, 1000 has to be replced with constants.KB |
n-rodriguez
force-pushed
the
fix/disk-computation
branch
from
4967ea9 to
1ed86ef
Compare
@bl4ko sorry, it's done |
Thank you!