fix: log sync errors #509
Merged
fix: log sync errors #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bl4ko
reviewed
Feb 26, 2025
| @@ -1171,6 +1171,7 @@ func (nbi *NetboxInventory) AddVM(ctx context.Context, newVM *objects.VM) (*obje | |||
| ) | |||
| patchedVM, err := service.Patch[objects.VM](ctx, nbi.NetboxAPI, oldVM.ID, diffMap) | |||
| if err != nil { | |||
| nbi.Logger.Errorf(ctx, "Error while patching %s : %s", newVM.Name, err) | |||
There was a problem hiding this comment.
This should rather be:
if err != nil {
return nil, fmt.Errorf("error patching %s: %s", newVM.Name, err)
} There was a problem hiding this comment.
I can give it a try but I'm afraid it won't solve my issue which is I only have 1 error reported by cluster :
2025/02/26 20:01:30 main.go:117 ERROR (cluster0.corp): failed to sync vmware VM foo.bar: unexpected status code: 400: {"disk":["The specified disk size (135000) must match the aggregate size of assigned virtual disks (135659)."]}
2025/02/26 20:01:30 main.go:117 ERROR (cluster1.corp): failed to sync vmware VM foo.bar: unexpected status code: 400: {"disk":["The specified disk size (844000) must match the aggregate size of assigned virtual disks (844711)."]}
2025/02/26 20:01:30 main.go:117 ERROR (cluster2.corp): failed to sync vmware VM foo.bar: unexpected status code: 400: {"disk":["The specified disk size (844000) must match the aggregate size of assigned virtual disks (844711)."]}There was a problem hiding this comment.
Yes this is because the sync of an external source fails on the first error.
There was a problem hiding this comment.
I think the solution for this whole problem is that, netbox-ssot takes care of vm disks.
There was a problem hiding this comment.
Yes this is because the sync of an external source fails on the first error.
I'm not sure this is the case. In the logs I have :
2025/02/26 22:45:47 add_items.go:1174 ERROR (cluster2.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (844000) must match the aggregate size of assigned virtual disks (844711)."]}
2025/02/26 22:46:01 add_items.go:1174 ERROR (cluster1.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (844000) must match the aggregate size of assigned virtual disks (844711)."]}
2025/02/26 22:46:04 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (69000) must match the aggregate size of assigned virtual disks (69062)."]}
2025/02/26 22:46:11 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (39000) must match the aggregate size of assigned virtual disks (39062)."]}
2025/02/26 22:46:12 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (239000) must match the aggregate size of assigned virtual disks (239062)."]}
2025/02/26 22:46:12 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (149000) must match the aggregate size of assigned virtual disks (149062)."]}
2025/02/26 22:46:14 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (39000) must match the aggregate size of assigned virtual disks (39062)."]}
2025/02/26 22:46:15 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (141000) must match the aggregate size of assigned virtual disks (141062)."]}
2025/02/26 22:46:16 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (208000) must match the aggregate size of assigned virtual disks (208490)."]}
2025/02/26 22:46:17 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (825000) must match the aggregate size of assigned virtual disks (25000)."]}
2025/02/26 22:46:19 main.go:117 ERROR (cluster2.corp): failed to sync vmware VM foo.bar: error patching foo.bar: unexpected status code: 400: {"disk":["The specified disk size (844000) must match the aggregate size of assigned virtual disks (844711)."]}
2025/02/26 22:46:19 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (278000) must match the aggregate size of assigned virtual disks (278828)."]}
2025/02/26 22:46:19 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (239000) must match the aggregate size of assigned virtual disks (239062)."]}
2025/02/26 22:46:20 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (239000) must match the aggregate size of assigned virtual disks (239062)."]}
2025/02/26 22:46:21 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (39000) must match the aggregate size of assigned virtual disks (39062)."]}
2025/02/26 22:46:21 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (239000) must match the aggregate size of assigned virtual disks (239062)."]}
2025/02/26 22:46:25 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (539000) must match the aggregate size of assigned virtual disks (539062)."]}
2025/02/26 22:46:26 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (135000) must match the aggregate size of assigned virtual disks (135659)."]}
2025/02/26 22:46:26 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (439000) must match the aggregate size of assigned virtual disks (439062)."]}
2025/02/26 22:46:31 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (89000) must match the aggregate size of assigned virtual disks (89062)."]}
2025/02/26 22:46:31 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (239000) must match the aggregate size of assigned virtual disks (239062)."]}
2025/02/26 22:46:32 main.go:117 ERROR (cluster1.corp): failed to sync vmware VM foo.bar: error patching foo.bar: unexpected status code: 400: {"disk":["The specified disk size (844000) must match the aggregate size of assigned virtual disks (844711)."]}
2025/02/26 22:46:36 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (239000) must match the aggregate size of assigned virtual disks (239062)."]}
2025/02/26 22:46:37 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (39000) must match the aggregate size of assigned virtual disks (39062)."]}
2025/02/26 22:46:38 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (105000) must match the aggregate size of assigned virtual disks (105062)."]}
2025/02/26 22:46:40 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (141000) must match the aggregate size of assigned virtual disks (141062)."]}
2025/02/26 22:46:41 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (1249000) must match the aggregate size of assigned virtual disks (1249062)."]}
2025/02/26 22:46:43 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (239000) must match the aggregate size of assigned virtual disks (239062)."]}
2025/02/26 22:46:45 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (105000) must match the aggregate size of assigned virtual disks (105062)."]}
2025/02/26 22:46:46 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (439000) must match the aggregate size of assigned virtual disks (439062)."]}
2025/02/26 22:46:48 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (249000) must match the aggregate size of assigned virtual disks (249062)."]}
2025/02/26 22:46:53 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (135000) must match the aggregate size of assigned virtual disks (135062)."]}
2025/02/26 22:46:54 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (1039000) must match the aggregate size of assigned virtual disks (1039062)."]}
2025/02/26 22:46:54 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (539000) must match the aggregate size of assigned virtual disks (539062)."]}
2025/02/26 22:47:01 add_items.go:1174 ERROR (cluster0.corp): Error while patching foo.bar : unexpected status code: 400: {"disk":["The specified disk size (319000) must match the aggregate size of assigned virtual disks (319688)."]}
2025/02/26 22:47:04 main.go:117 ERROR (cluster0.corp): failed to sync vmware VM foo.bar: error patching dev-data01.mar02: unexpected status code: 400: {"disk":["The specified disk size (69000) must match the aggregate size of assigned virtual disks (69062)."]}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log sync errors :
(logs have been anonymized)
Fix #508
You may have a better solution.