Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vmware): allow deletion of VirtualDisk #520

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(vmware): allow deletion of VirtualDisk #520

wants to merge 1 commit into from
+2 −0

Conversation

n-rodriguez
Copy link
Contributor

Thank you!

@bl4ko
Copy link
Member

bl4ko commented Mar 1, 2025 •
edited
Loading

Hello, nice catch. Thanks!

Could you just use formatter like golines, to avoid golangci long lines rule (120 chars max).

Something like:

go install github.com/segmentio/golines@latest
golines ./internal/netbox/inventory/delete_items.go

@bl4ko
Copy link
Member

bl4ko commented Mar 3, 2025

@n-rodriguez

@n-rodriguez n-rodriguez force-pushed the fix/delete-virtual-disk branch from 773b3e2 to 53aca76 Compare March 4, 2025 20:50
@n-rodriguez
Copy link
Contributor Author

@bl4ko done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n-rodriguez @bl4ko