Fix PlayerTimeSlider not being draggable (#447)

SRGSSR · Feb 20, 2024 · 49eed2c · 49eed2c
1 parent 4d104df
commit 49eed2c
Show file tree

Hide file tree

Showing 6 changed files with 32 additions and 3 deletions.
diff --git a/pillarbox-analytics/build.gradle.kts b/pillarbox-analytics/build.gradle.kts
@@ -1,3 +1,5 @@
+import org.gradle.api.tasks.testing.logging.TestExceptionFormat
+
 /*
  * Copyright (c) SRG SSR. All rights reserved.
  * License information is available from the LICENSE file.
@@ -58,6 +60,10 @@ android {
     }
 }
 
+tasks.withType<Test>().configureEach {
+    testLogging.exceptionFormat = TestExceptionFormat.FULL
+}
+
 dependencies {
     implementation(libs.comscore)
     implementation(libs.tagcommander.core)

diff --git a/pillarbox-core-business/build.gradle.kts b/pillarbox-core-business/build.gradle.kts
@@ -1,3 +1,5 @@
+import org.gradle.api.tasks.testing.logging.TestExceptionFormat
+
 /*
  * Copyright (c) SRG SSR. All rights reserved.
  * License information is available from the LICENSE file.
@@ -53,6 +55,10 @@ android {
     }
 }
 
+tasks.withType<Test>().configureEach {
+    testLogging.exceptionFormat = TestExceptionFormat.FULL
+}
+
 dependencies {
     api(project(":pillarbox-analytics"))
     api(project(":pillarbox-player"))

diff --git a/pillarbox-player/build.gradle.kts b/pillarbox-player/build.gradle.kts
@@ -1,3 +1,5 @@
+import org.gradle.api.tasks.testing.logging.TestExceptionFormat
+
 /*
  * Copyright (c) SRG SSR. All rights reserved.
  * License information is available from the LICENSE file.
@@ -65,6 +67,10 @@ android {
     }
 }
 
+tasks.withType<Test>().configureEach {
+    testLogging.exceptionFormat = TestExceptionFormat.FULL
+}
+
 dependencies {
     implementation(libs.androidx.annotation)
     implementation(libs.androidx.core)

diff --git a/pillarbox-player/src/test/java/ch/srgssr/pillarbox/player/tracker/MediaItemTrackerTest.kt b/pillarbox-player/src/test/java/ch/srgssr/pillarbox/player/tracker/MediaItemTrackerTest.kt
@@ -566,15 +566,18 @@ class MediaItemTrackerTest {
             )
             prepare()
             play()
+            seekTo(FakeMediaItemSource.NEAR_END_POSITION_MS)
         }
 
         TestPlayerRunHelper.runUntilPlaybackState(player, Player.STATE_READY)
         TestPlayerRunHelper.runUntilTimelineChanged(player)
 
+        fakeClock.advanceTime(FakeMediaItemSource.NEAR_END_POSITION_MS)
+
         verifyOrder {
-            fakeMediaItemTracker.start(any(), FakeMediaItemTracker.Data(firstMediaId))
-            fakeMediaItemTracker.stop(any(), MediaItemTracker.StopReason.EoF, any())
-            fakeMediaItemTracker.start(any(), FakeMediaItemTracker.Data(secondMediaId))
+            fakeMediaItemTracker.start(player, FakeMediaItemTracker.Data(firstMediaId))
+            fakeMediaItemTracker.stop(player, MediaItemTracker.StopReason.EoF, any())
+            fakeMediaItemTracker.start(player, FakeMediaItemTracker.Data(secondMediaId))
         }
         confirmVerified(fakeMediaItemTracker)
     }

diff --git a/pillarbox-ui/build.gradle.kts b/pillarbox-ui/build.gradle.kts
@@ -1,3 +1,5 @@
+import org.gradle.api.tasks.testing.logging.TestExceptionFormat
+
 /*
  * Copyright (c) SRG SSR. All rights reserved.
  * License information is available from the LICENSE file.
@@ -50,6 +52,10 @@ android {
     }
 }
 
+tasks.withType<Test>().configureEach {
+    testLogging.exceptionFormat = TestExceptionFormat.FULL
+}
+
 dependencies {
     api(project(":pillarbox-player"))
 

diff --git a/pillarbox-ui/src/main/java/ch/srgssr/pillarbox/ui/ProgressTrackerState.kt b/pillarbox-ui/src/main/java/ch/srgssr/pillarbox/ui/ProgressTrackerState.kt
@@ -4,13 +4,15 @@
  */
 package ch.srgssr.pillarbox.ui
 
+import androidx.compose.runtime.Stable
 import androidx.media3.common.Player
 import kotlinx.coroutines.flow.StateFlow
 import kotlin.time.Duration
 
 /**
  * Interface used to subscribe to and update the [Player] progression.
  */
+@Stable
 interface ProgressTrackerState {
     /**
      * Emits the current progress, which can be either the value being manually set, or the actual [Player] progress.