Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video doesn't fit when PlayerSurface size changed on Android Pixels devices #515

Closed
1 task
StaehliJ opened this issue Apr 29, 2024 · 1 comment · Fixed by #618
Closed
1 task

Video doesn't fit when PlayerSurface size changed on Android Pixels devices #515

StaehliJ opened this issue Apr 29, 2024 · 1 comment · Fixed by #618
Labels
bug Something isn't working

Comments

@StaehliJ
Copy link
Contributor

As a user / integrator I want to change the video size during playback and keep the correct aspect ratio on every devices.

Current state

We can reproduce the bug with Pixels device by running the showcase "resizable player".

On samsung device, the correct behavior is

Image

Image

After changing the video, the crosshair point to the same location on the video.

The same case but on a Pixel 8 Android 14 device

Image

Even at startup the crosshair is not placed correctly. The video aspect ratio is know a bit after and the video surface seems not to be updated.

Image

After changing the video size, the drawing of the video doesn't follow it.

Acceptance criteria

  • When SurfaceView is changing size, the video drawing is correctly applied.

Tasks

  • Create a Custom Android View
@MGaetan89 MGaetan89 self-assigned this Apr 29, 2024
@StaehliJ
Copy link
Contributor Author

This issue is related to androidx/media#1237

@MGaetan89 MGaetan89 removed their assignment Apr 30, 2024
@MGaetan89 MGaetan89 added the bug Something isn't working label May 13, 2024
@MGaetan89 MGaetan89 linked a pull request Jul 26, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants