Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to AndroidX Media3 1.4.0 #618

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Update to AndroidX Media3 1.4.0 #618

merged 3 commits into from
Jul 26, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Jul 1, 2024

Pull request

Description

This PR updates AndroidX Media3 to 1.4.0. This new version should fix the following issues:

Release notes:

Changes made

  • Self-explanatory.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 self-assigned this Jul 1, 2024
Copy link

github-actions bot commented Jul 1, 2024

Code Coverage

Overall Project 48.78% -0.91% 🟢
Files changed 15.48% 🟢

Module Coverage
:pillarbox-player 50.47% -0.67% 🟢
Kover Gradle Plugin XML report for :plugins 9.52% 🟢
:pillarbox-ui 0.09% -3.15% 🟢
Files
Module File Coverage
:pillarbox-player PillarboxLoadControl.kt 100% 🟢
PillarboxMediaLibrarySession.kt 0% -12.3% 🟢
PillarboxMediaController.kt 0% -0.44% 🟢
PillarboxMediaSession.kt 0% -3.16% 🟢
PillarboxNotificationManager.kt 0% -7.55% 🟢
PlaybackService.kt 0% -2.51% 🟢
Kover Gradle Plugin XML report for :plugins ProjectExtensions.kt 0% 🟢
:pillarbox-ui PlayerSurface.kt 0.51% -17.2% 🟢

@MGaetan89 MGaetan89 force-pushed the media3_1.4.0 branch 3 times, most recently from 0f6368b to 8997c36 Compare July 2, 2024 08:55
@MGaetan89 MGaetan89 marked this pull request as ready for review July 2, 2024 09:31
@MGaetan89 MGaetan89 marked this pull request as draft July 3, 2024 06:37
@MGaetan89 MGaetan89 changed the title Update to AndroidX Media3 1.4.0-beta01 Update to AndroidX Media3 1.4.0-rc01 Jul 11, 2024
@MGaetan89 MGaetan89 marked this pull request as ready for review July 11, 2024 18:51
@MGaetan89 MGaetan89 requested a review from StaehliJ July 11, 2024 18:51
@StaehliJ
Copy link
Contributor

In order to fix issue #515 we have to apply the same workaround that Media3 has done here

@MGaetan89
Copy link
Member Author

In order to fix issue #515 we have to apply the same workaround that Media3 has done here

I've added the workaround in 9dd5c35

Copy link
Contributor

@StaehliJ StaehliJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep track of Media3 when and if we can remove that workaround.

@MGaetan89
Copy link
Member Author

AndroidX Media3 1.4.0 stable should be released around the 24th of July: androidx/media@68e8d9c

@MGaetan89 MGaetan89 changed the title Update to AndroidX Media3 1.4.0-rc01 Update to AndroidX Media3 1.4.0 Jul 25, 2024
@StaehliJ StaehliJ added this pull request to the merge queue Jul 26, 2024
Merged via the queue into main with commit f427c0c Jul 26, 2024
10 checks passed
@StaehliJ StaehliJ deleted the media3_1.4.0 branch July 26, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
2 participants