Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

182 improve page view and event #183

Merged
merged 7 commits into from
Jul 24, 2023
Merged

Conversation

StaehliJ
Copy link
Contributor

Pull request

Description

After reading some documentation, it appears that page view can't have common concept between Commanders Act and ComScore. So we decide to "expose" the usage of those underlying library. We also choose to force mandatory field in object and the optionnel can be send with custom labels.

Changes made

  • SRGAnalytics.sendPageView take two object, one for ComScore and one for CommandersAct

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ linked an issue Jul 21, 2023 that may be closed by this pull request
10 tasks
@StaehliJ StaehliJ merged commit fb7140f into main Jul 24, 2023
4 checks passed
@StaehliJ StaehliJ deleted the 182-improve-page-view-and-event branch July 24, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve page view and event APIs
1 participant