Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple page view to lists and search #188

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Jul 26, 2023

Pull request

Description

Lists tab and search tab are now tracked.

Changes made

  • Add page view to search tab
  • Add page view to list tab with static page view title.

Improvements

  • Page view in list could be enhanced with inputs parameters like bu, radio channel title, topic title, show title.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ added this to the Analytics milestone Jul 26, 2023
@StaehliJ StaehliJ added the enhancement New feature or request label Jul 26, 2023
@StaehliJ StaehliJ self-assigned this Jul 26, 2023
@StaehliJ StaehliJ merged commit 2ba4e75 into main Jul 26, 2023
4 checks passed
@StaehliJ StaehliJ deleted the improve-demo-page-view branch July 26, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant