Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix viewAspectRatio badly computed #205

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Aug 14, 2023

Description

Fix issue when displaying a 4:3 video in the demo with playlist view. The video aspect ratio was incorrectly computed and so the video may be displayed outside its parent.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ added the bug Something isn't working label Aug 14, 2023
@StaehliJ StaehliJ requested a review from defagos August 14, 2023 07:34
The issue appears when playing a 4:3 content in the demo with player view with playlist.
@StaehliJ StaehliJ force-pushed the fix-video-display-outside-the-parent-view branch from dd77bb3 to 20ee8f8 Compare August 14, 2023 08:26
@StaehliJ StaehliJ merged commit 1911c9e into main Aug 14, 2023
4 checks passed
@StaehliJ StaehliJ deleted the fix-video-display-outside-the-parent-view branch August 14, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants