Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

217 load mediacomposition without segments #219

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

StaehliJ
Copy link
Contributor

Pull request

Description

When playing a segment urn, the played media is the segment related media and not the full length media.

Changes made

  • Add query parameter onlyChapter to MediaCompositionService.
  • MediaCompositionDataSourceImpl load MediaComposition without segments.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ linked an issue Aug 22, 2023 that may be closed by this pull request
1 task
@StaehliJ StaehliJ requested a review from defagos August 22, 2023 08:30
Co-authored-by: Walid Kayhal <[email protected]>
@StaehliJ StaehliJ merged commit 830630a into main Aug 23, 2023
4 checks passed
@StaehliJ StaehliJ deleted the 217-load-mediacomposition-without-segments branch August 23, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load MediaComposition without segments
3 participants