Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

211 version catalog migration #221

Merged
merged 8 commits into from
Aug 23, 2023
Merged

211 version catalog migration #221

merged 8 commits into from
Aug 23, 2023

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Aug 23, 2023

Description

Migrate dependence management to version catalog.

Changes made

Self-explanatory

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ linked an issue Aug 23, 2023 that may be closed by this pull request
implementation(Dependencies.Compose.activity)
implementation(Dependencies.Compose.navigation)
implementation(Dependencies.Compose.viewmodel)
implementation("androidx.lifecycle:lifecycle-viewmodel-compose:2.6.1")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [Android Lint] reported by reviewdog 🐶
UseTomlInstead: Use version catalog instead

implementation(Dependencies.Compose.navigation)
implementation(Dependencies.Compose.viewmodel)
implementation("androidx.lifecycle:lifecycle-viewmodel-compose:2.6.1")
implementation("androidx.activity:activity-compose:1.7.2")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [Android Lint] reported by reviewdog 🐶
UseTomlInstead: Use version catalog instead

implementation(Dependencies.Compose.viewmodel)
implementation("androidx.lifecycle:lifecycle-viewmodel-compose:2.6.1")
implementation("androidx.activity:activity-compose:1.7.2")
implementation("androidx.navigation:navigation-compose:2.7.0")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [Android Lint] reported by reviewdog 🐶
UseTomlInstead: Use version catalog instead

@StaehliJ StaehliJ merged commit 209b000 into main Aug 23, 2023
4 checks passed
@StaehliJ StaehliJ deleted the 211-version-catalog-migration branch August 23, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use version catalog to manage dependencies
2 participants