Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Windows invalid characters from files #350

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Nov 29, 2023

Pull request

Description

The goal of this PR is to allow Microsoft Windows user to check out the project without any issues.

Changes made

  • Remove invalid Windows files name characters

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ linked an issue Nov 29, 2023 that may be closed by this pull request
4 tasks
@StaehliJ StaehliJ force-pushed the 349-make-project-build-on-windows branch from 9ba2fed to bc42b0e Compare November 29, 2023 09:40
@MGaetan89
Copy link
Member

MGaetan89 commented Nov 29, 2023

Should we update our GitHub Actions workflow to build the project on Windows too?
It could be done in the scope of #339

@StaehliJ
Copy link
Contributor Author

Should we update our GitHub Actions workflow to build the project on Windows too? It could be done in the scope of #339

I'm not sur if there is a window runner that can run virtual android device. This why we have to run androidTest on a macOS runner.

@MGaetan89
Copy link
Member

Should we update our GitHub Actions workflow to build the project on Windows too? It could be done in the scope of #339

I'm not sur if there is a window runner that can run virtual android device. This why we have to run androidTest on a macOS runner.

We could run the Android Lint, Detekt and Unit Tests steps in both Ubuntu and Windows, and keep the Android Tests on macOS only.

@StaehliJ StaehliJ force-pushed the 349-make-project-build-on-windows branch from 4d9be20 to 72b1fd8 Compare November 29, 2023 14:58
@StaehliJ StaehliJ merged commit 13fc1e1 into main Nov 29, 2023
4 checks passed
@StaehliJ StaehliJ deleted the 349-make-project-build-on-windows branch November 29, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make project build on Windows
2 participants