-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Windows invalid characters from files #350
Conversation
9ba2fed
to
bc42b0e
Compare
...ss/src/androidTest/java/ch/srgssr/pillarbox/core/business/LocalMediaCompositionDataSource.kt
Outdated
Show resolved
Hide resolved
...ss/src/androidTest/java/ch/srgssr/pillarbox/core/business/LocalMediaCompositionDataSource.kt
Show resolved
Hide resolved
Should we update our GitHub Actions workflow to build the project on Windows too? |
I'm not sur if there is a window runner that can run virtual android device. This why we have to run androidTest on a macOS runner. |
We could run the Android Lint, Detekt and Unit Tests steps in both Ubuntu and Windows, and keep the Android Tests on macOS only. |
…ox/core/business/LocalMediaCompositionDataSource.kt Co-authored-by: Gaëtan Muller <[email protected]>
4d9be20
to
72b1fd8
Compare
Pull request
Description
The goal of this PR is to allow Microsoft Windows user to check out the project without any issues.
Changes made
Checklist
main
branch.