-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve navigation in the TV demo app #353
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
MGaetan89
force-pushed
the
340-improve-top-bar-navigation-in-demo-tv
branch
3 times, most recently
from
November 30, 2023 14:34
a6b468f
to
13461f7
Compare
We could improve top level focus selection. When top level menu is focus, request focus first on the current selected item. |
MGaetan89
force-pushed
the
340-improve-top-bar-navigation-in-demo-tv
branch
from
December 5, 2023 10:32
13461f7
to
411ee69
Compare
StaehliJ
force-pushed
the
340-improve-top-bar-navigation-in-demo-tv
branch
from
December 12, 2023 16:52
832f555
to
5695b22
Compare
MGaetan89
commented
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment on the code, will test the new version now
pillarbox-demo-tv/src/main/java/ch/srgssr/pillarbox/demo/tv/ui/TVDemoTopBar.kt
Outdated
Show resolved
Hide resolved
StaehliJ
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This PR improves the navigation in the TV demo app.
Changes made
Checklist
main
branch.