Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve navigation in the TV demo app #353

Merged
merged 13 commits into from
Dec 13, 2023

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Nov 29, 2023

Pull request

Description

This PR improves the navigation in the TV demo app.

Changes made

  • When pressing back while on a grid:
    • If the focused item is not on the first row, we give the focus to the first item of the grid, and scroll to it
    • If the focused item is on the first row:
      • If we are on the root screen, we give focus to the top navigation
      • If we are on a nested screen, we navigate back
  • Remove some dead code

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Nov 29, 2023 that may be closed by this pull request
1 task
@MGaetan89 MGaetan89 force-pushed the 340-improve-top-bar-navigation-in-demo-tv branch 3 times, most recently from a6b468f to 13461f7 Compare November 30, 2023 14:34
@StaehliJ
Copy link
Contributor

StaehliJ commented Dec 4, 2023

We could improve top level focus selection. When top level menu is focus, request focus first on the current selected item.

@MGaetan89 MGaetan89 force-pushed the 340-improve-top-bar-navigation-in-demo-tv branch from 13461f7 to 411ee69 Compare December 5, 2023 10:32
@StaehliJ StaehliJ force-pushed the 340-improve-top-bar-navigation-in-demo-tv branch from 832f555 to 5695b22 Compare December 12, 2023 16:52
Copy link
Member Author

@MGaetan89 MGaetan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment on the code, will test the new version now

@StaehliJ StaehliJ added this pull request to the merge queue Dec 13, 2023
Merged via the queue into main with commit aef1beb Dec 13, 2023
7 checks passed
@StaehliJ StaehliJ deleted the 340-improve-top-bar-navigation-in-demo-tv branch December 13, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve top bar navigation in demo tv
2 participants