Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add playback settings to TV demo app #363

Merged
merged 7 commits into from
Dec 14, 2023

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Dec 8, 2023

Pull request

Description

This PR adds the ability to change the playback speed, audio language, and subtitle language.

Changes made

  • Update TvPlayerView to display a settings icon, which allows the user to change the audio track, subtitle, and playback speed
  • Update all the *AsState() method methods to actually return a State
  • Update the Modifier.handleDPadKeyEvents so it uses Compose's type and supports up/down events too
  • Fix some of the Lint warnings reported here

Screenshots

Description Screenshot
Settings menu Screenshot_20231214_093710
Audio track setting Screenshot_20231214_093719
Subtitle setting Screenshot_20231214_093729
Speed setting Screenshot_20231214_093739
Updated settings menu Screenshot_20231214_093745

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Dec 8, 2023 that may be closed by this pull request
1 task
@MGaetan89 MGaetan89 force-pushed the 272-playback-settings-on-android-tv-demo branch from 8aa6001 to 42d8472 Compare December 14, 2023 08:21
@MGaetan89 MGaetan89 marked this pull request as ready for review December 14, 2023 08:41
@StaehliJ StaehliJ added this pull request to the merge queue Dec 14, 2023
Merged via the queue into main with commit 2a7d91c Dec 14, 2023
7 checks passed
@StaehliJ StaehliJ deleted the 272-playback-settings-on-android-tv-demo branch December 14, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playback settings on Android TV demo
2 participants