Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve settings menu on TV demo #366

Merged
merged 9 commits into from
Dec 15, 2023
Merged

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Dec 15, 2023

Pull request

Description

This PR improves the player settings menu in the TV demo app, and reduce code duplication.

Changes made

  • Improve light mode support on TV
  • Add the missing "Reset to default" option to audio tracks and subtitles settings
  • Add the missing "Disabled" option to audio tracks and subtitles settings
  • Reorder settings on TV to match what was done in the mobile demo
  • Move the PlayerSettingsViewModel to pillarbox-demo-shared, so it can be used in both demo app. I've also moved a bunch of logic to it (settings definition, settings actions, ...)

Screenshots

Light mode on TV:
Screenshot_20231215_120813

The rest of the changes don't impact the UI too much (except the reordering of settings on TV).

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Dec 15, 2023 that may be closed by this pull request
Copy link
Contributor

@StaehliJ StaehliJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When opening tracks settings in the Mobile demo, it select first disabled and then the one currently selected.

@MGaetan89
Copy link
Member Author

When opening tracks settings in the Mobile demo, it select first disabled and then the one currently selected.

Should be fixed now.

I've also removed the popBackStack() when clicking on a track, so the behaviour is aligned between mobile and TV.

@MGaetan89 MGaetan89 force-pushed the 365-improve-settings-menu-on-tv-demo branch from b5a6929 to f8e77bd Compare December 15, 2023 16:30
@StaehliJ StaehliJ added this pull request to the merge queue Dec 15, 2023
Merged via the queue into main with commit 6fa8346 Dec 15, 2023
7 checks passed
@StaehliJ StaehliJ deleted the 365-improve-settings-menu-on-tv-demo branch December 15, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve settings menu on TV demo
2 participants