-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve settings menu on TV demo #366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When opening tracks settings in the Mobile demo, it select first disabled and then the one currently selected.
Should be fixed now. I've also removed the |
b5a6929
to
f8e77bd
Compare
Pull request
Description
This PR improves the player settings menu in the TV demo app, and reduce code duplication.
Changes made
PlayerSettingsViewModel
topillarbox-demo-shared
, so it can be used in both demo app. I've also moved a bunch of logic to it (settings definition, settings actions, ...)Screenshots
Light mode on TV:
The rest of the changes don't impact the UI too much (except the reordering of settings on TV).
Checklist
main
branch.