359 use pillarbox icon for android tv #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
pillarbox-demo-tv/src/main/res/mipmap-anydpi-v26/ic_launcher_pillarbox_round.xml
Fixed
Show fixed
Hide fixed
Comment on lines
+6
to
+9
| <adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android"> | ||
| <background android:drawable="@color/ic_launcher_pillarbox_background"/> | ||
| <foreground android:drawable="@mipmap/ic_launcher_pillarbox_foreground"/> | ||
| </adaptive-icon> |
Check warning
Code scanning / Android Lint
Monochrome icon is not defined Warning
There was a problem hiding this comment.
Android TV doesn't support themed icon
MGaetan89
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
Add pillarbox launcher icons and tv banner. For some reason, the tv banner is not correctly showed on the applications launcher in Android TV.
Changes made
Checklist
mainbranch.