Remove Modifier.handleDPadKeyEvents
from pillarbox-ui
#384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This PR removes
Modifier.handleDPadKeyEvents
frompillarbox-ui
. Instead, we now have a dedicated private extension where needed (ie. inDelayedVisibilityState.kt
), and a new extension inpillarbox-demo-tv
.Changes made
Modifier.handleDPadKeyEvents
frompillarbox-ui
Modifier.onDpadEvent
inpillarbox-demo-tv
Modifier.handleDPadKeyEvents
andModifier.onPreviewKeyEvent
inpillarbox-demo-tv
withModifier.onDpadEvent
Modifier.toggleable
inDelayedVisibilityState
to not break theModifier
chainChecklist
main
branch.