Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Modifier.handleDPadKeyEvents from pillarbox-ui #384

Merged

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Dec 20, 2023

Pull request

Description

This PR removes Modifier.handleDPadKeyEvents from pillarbox-ui. Instead, we now have a dedicated private extension where needed (ie. in DelayedVisibilityState.kt), and a new extension in pillarbox-demo-tv.

Changes made

  • Remove Modifier.handleDPadKeyEvents from pillarbox-ui
  • Create Modifier.onDpadEvent in pillarbox-demo-tv
  • Replace all usages of Modifier.handleDPadKeyEvents and Modifier.onPreviewKeyEvent in pillarbox-demo-tv with Modifier.onDpadEvent
  • Fix Modifier.toggleable in DelayedVisibilityState to not break the Modifier chain

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Dec 20, 2023 that may be closed by this pull request
@MGaetan89 MGaetan89 force-pushed the 379-remove-modifierhandledpadkeyevents-from-pillarbox-ui branch from 313f85d to c40498a Compare December 21, 2023 08:14
@MGaetan89 MGaetan89 added this pull request to the merge queue Dec 21, 2023
Merged via the queue into main with commit 5c812aa Dec 21, 2023
7 checks passed
@MGaetan89 MGaetan89 deleted the 379-remove-modifierhandledpadkeyevents-from-pillarbox-ui branch December 21, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Modifier.handleDPadKeyEvents from pillarbox-ui
2 participants