Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

373 pillarbox web is available in a webview #385

Closed
wants to merge 3 commits into from
Closed

373 pillarbox web is available in a webview #385

wants to merge 3 commits into from

Conversation

StaehliJ
Copy link
Contributor

Pull request

Description

The goal of this PR is to add a example to Pillarbox demo mobile to test Pillarbox-web inside a WebView.

We aren't sur if Pillarbox-Android is the good place to display that kind of demo, maybe in pillarbox-web repository or inside a seperate repository.

Changes made

  • Add a WebView demo

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ linked an issue Dec 21, 2023 that may be closed by this pull request
Pillarbox Web is available in a webview #373
Closed
@StaehliJ StaehliJ closed this Jan 12, 2024
@StaehliJ StaehliJ deleted the 373-pillarbox-web-is-available-in-a-webview branch January 12, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pillarbox Web is available in a webview
2 participants
@StaehliJ @MGaetan89