Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast seek #386

Merged
merged 17 commits into from
Jan 5, 2024
Merged

Fast seek #386

merged 17 commits into from
Jan 5, 2024

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Jan 4, 2024

Description

The goal of this PR is to make an old smooth seeking poc branches. There is a lot of room for improvements.

Changes made

  • Add PillarboxLoadControl to optimize loading while smooth seeking.
  • Add SmoothProgressTrackerState with new interface to handle seeking ui event ProgressTrackerState.
  • Add a show case to enable / disable smooth seeking.

Issues

  • While smooth seeking, it may downgrade the video quality and doesn't restore the quality before seeking.
  • No user friendly, a public api still have to be made.
  • Could work better for HLS with trick play.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ linked an issue Jan 4, 2024 that may be closed by this pull request
1 task
@StaehliJ StaehliJ marked this pull request as ready for review January 4, 2024 12:49
MGaetan89 added a commit that referenced this pull request Jan 5, 2024
@StaehliJ StaehliJ added this pull request to the merge queue Jan 5, 2024
Merged via the queue into main with commit 04e2875 Jan 5, 2024
8 checks passed
@StaehliJ StaehliJ deleted the fast-seek branch January 5, 2024 09:36
@MGaetan89 MGaetan89 mentioned this pull request Jan 5, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fast seek
2 participants