Smooth seeking #391
Merged
Smooth seeking #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
MGaetan89
approved these changes
Jan 15, 2024
...box-demo/src/main/java/ch/srgssr/pillarbox/demo/ui/showcases/smooth/SmoothSeekingShowCase.kt
Outdated
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/PillarboxLoadControl.kt
Outdated
Show resolved
Hide resolved
pillarbox-ui/src/main/java/ch/srgssr/pillarbox/ui/SmoothProgressTrackerState.kt
Outdated
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/PillarboxPlayer.kt
Outdated
Show resolved
Hide resolved
StaehliJ
force-pushed
the
smooth-seeking
branch
from
e549c76
to
0c52ec3
Compare
MGaetan89
approved these changes
Jan 19, 2024
Co-authored-by: Gaëtan Muller <[email protected]>
…arboxPlayer.kt Co-authored-by: Gaëtan Muller <[email protected]>
MGaetan89
force-pushed
the
smooth-seeking
branch
from
194e3fe
to
215f5f3
Compare
MGaetan89
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
The goal of this PR is to add smooth seeking to
PillarboxPlayer.Smooth seeking work better when the playback is paused and the seek behavior try to synchronize to I-Frames.
(SeekParameters.CLOSEST_SYNCH). It obviously work best when current stream contains I-Frames .Changes made
PillarboxforPillarboxPlayerto handle smooth seeking. It allow to make likeForwardingPlayerbut withPillarboxPlayerPillarboxPlayer.smoothSeekingEnabledto enable or disable smooth seeking.SmoothProgressTrackerStatedoesn't change playback speed. It only pause the playback, disable needed tracks and enable smoothSeeking.PillarboxLoadControlto improve playback start.Player.seekTois called, it is disabled for other seek event like seek forward or back.Checklist
mainbranch.