Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ubuntu-latest for Android Tests and enable KVM #399

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Jan 19, 2024

Pull request

Description

GitHub now provides more powerful Ubuntu/Windows machines for GitHub Actions, free for Open Source projects.
The goal of this PR is to migrate to these new machines, instead of the current macos-latest, to see if we can get some speed improvements for the Android Tests step.

Fresh build (main) Fresh build (this PR) Build with cache (this PR)
Screenshot 2024-01-19 at 17 23 36 Screenshot 2024-01-19 at 17 01 11 Screenshot 2024-01-21 at 16 59 12 

Changes made

  • Switch the Android Tests step of the build workflow to use ubuntu-latest instead of macos-latest
  • Use a dedicated gradle.properties file for CI, to disable some unnecessary features
  • Try to fix nightly.yml (see Fix nightly workflow #396)
  • Update Dependency Analysis Plugin to 1.29.0

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 added bug Something isn't working enhancement New feature or request labels Jan 19, 2024
@MGaetan89 MGaetan89 added this to the 1.0.0 milestone Jan 19, 2024
@MGaetan89 MGaetan89 linked an issue Jan 19, 2024 that may be closed by this pull request
@MGaetan89 MGaetan89 self-assigned this Jan 19, 2024
@MGaetan89 MGaetan89 marked this pull request as ready for review January 21, 2024 16:00
@StaehliJ StaehliJ added this pull request to the merge queue Jan 22, 2024
Merged via the queue into main with commit d44c933 Jan 22, 2024
14 checks passed
@StaehliJ StaehliJ deleted the gha_build_ubuntu_kvm branch January 22, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Fix nightly workflow
2 participants