Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

400 single showcase file #410

Merged
merged 9 commits into from
Jan 25, 2024
Merged

400 single showcase file #410

merged 9 commits into from
Jan 25, 2024

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Jan 23, 2024 •
edited by MGaetan89
Loading

Pull request

Description

The goal of this PR is to simplify showcases by remove not necessarily files and improving codes.

Changes made

  • Self explanatory

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ marked this pull request as ready for review January 23, 2024 15:42
@MGaetan89 MGaetan89 linked an issue Jan 23, 2024 that may be closed by this pull request
One showcase in one file #400
Closed
1 task
MGaetan89
MGaetan89 reviewed Jan 24, 2024
View reviewed changes
pillarbox-demo/src/main/java/ch/srgssr/pillarbox/demo/ui/player/SimplePlayerActivity.kt Show resolved Hide resolved
pillarbox-demo/src/main/java/ch/srgssr/pillarbox/demo/ui/player/SimplePlayerActivity.kt Outdated Show resolved Hide resolved
.../src/main/java/ch/srgssr/pillarbox/demo/ui/showcases/integrations/MediaControllerActivity.kt Show resolved Hide resolved
pillarbox-demo/src/main/java/ch/srgssr/pillarbox/demo/ui/showcases/layouts/SimpleStory.kt Show resolved Hide resolved
pillarbox-demo/src/main/java/ch/srgssr/pillarbox/demo/ui/showcases/misc/MultiPlayerShowcase.kt Outdated Show resolved Hide resolved
...box-demo/src/main/java/ch/srgssr/pillarbox/demo/ui/showcases/misc/ResizablePlayerShowcase.kt Show resolved Hide resolved
...-demo/src/main/java/ch/srgssr/pillarbox/demo/ui/showcases/misc/UpdatableMediaItemShowcase.kt Show resolved Hide resolved
@StaehliJ StaehliJ added this pull request to the merge queue Jan 25, 2024
Merged via the queue into main with commit a15c479 Jan 25, 2024
8 checks passed
@StaehliJ StaehliJ deleted the 400-single-showcase-file branch January 25, 2024 14:08
MGaetan89 added a commit that referenced this pull request Jan 25, 2024
@StaehliJ @MGaetan89
400 single showcase file (#410)
cb8ae66 
Co-authored-by: Gaëtan Muller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

One showcase in one file
2 participants
@StaehliJ @MGaetan89