Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unit tests in pillarbox-analytics #411

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Jan 23, 2024

Pull request

Description

This PR updates the unit tests in pillarbox-analytics.

Changes made

  • Use kotlin-test instead of jUnit annotations (@Before, @Test, ...)
  • Move tests from ComScoreEventTest inside the right package
  • Move tests from CommandersActEventTest inside the right package, and split it in different classes
  • Add additional test to TestSRGAnalyticsPageViews

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Jan 23, 2024 that may be closed by this pull request
@MGaetan89 MGaetan89 force-pushed the 407-update-code-coverage-of-pillarbox-analytics branch from 855cad0 to 67feb38 Compare January 24, 2024 07:40
@MGaetan89 MGaetan89 added this pull request to the merge queue Jan 25, 2024
Merged via the queue into main with commit e3d2aad Jan 25, 2024
8 checks passed
@MGaetan89 MGaetan89 deleted the 407-update-code-coverage-of-pillarbox-analytics branch January 25, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update code coverage of pillarbox-analytics
2 participants