Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

416 use legacy uniqueid after migration commanders act v4x to v5x #417

Merged
merged 2 commits into from
Jan 25, 2024
Merged

416 use legacy uniqueid after migration commanders act v4x to v5x #417

merged 2 commits into from
Jan 25, 2024

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Jan 25, 2024 •
edited
Loading

Description

This PR uses the same unique identifier between v4 and v5, ensuring users are identified correctly between app updates to v5. The same change has been made for Apple at SRGSSR/pillarbox-apple#752

Changes made

  • Override SDK identifier.
  • Update to Commanders Act SDK 5.4.4 so that required APIs are available.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Jan 25, 2024 that may be closed by this pull request
Use Legacy UniqueID after migration commanders act v4.x to v5.x #416
Closed
@StaehliJ StaehliJ added this pull request to the merge queue Jan 25, 2024
Merged via the queue into main with commit 89ee9de Jan 25, 2024
8 checks passed
@StaehliJ StaehliJ deleted the 416-use-legacy-uniqueid-after-migration-commanders-act-v4x-to-v5x branch January 25, 2024 16:27
MGaetan89 pushed a commit that referenced this pull request Jan 25, 2024
@StaehliJ @MGaetan89
416 use legacy uniqueid after migration commanders act v4x to v5x (#417)
63c2898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Legacy UniqueID after migration commanders act v4.x to v5.x
2 participants
@StaehliJ @MGaetan89