Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

426 add some spaces to position indicator #444

Merged
merged 5 commits into from
Feb 20, 2024
Merged

426 add some spaces to position indicator #444

merged 5 commits into from
Feb 20, 2024

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Feb 16, 2024 •
edited
Loading

Pull request

Description

The goal of this PR is to improve current position and duration when displayed with light theme. The duration is set to 0 when it's duration is not known.

Changes made

  • Self-explanatory

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ marked this pull request as draft February 16, 2024 14:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 16, 2024 •
edited
Loading

Code Coverage

Overall Project 45.93% 🟢

There is no coverage information present for the Files changed

@StaehliJ StaehliJ marked this pull request as ready for review February 16, 2024 14:35
@MGaetan89 MGaetan89 linked an issue Feb 16, 2024 that may be closed by this pull request
Add some spaces to position indicator #426
Closed
1 task
@MGaetan89 MGaetan89 force-pushed the 426-add-some-spaces-to-position-indicator branch from 8a141f9 to 967d98f Compare February 20, 2024 13:48
@StaehliJ StaehliJ added this pull request to the merge queue Feb 20, 2024
Merged via the queue into main with commit db93449 Feb 20, 2024
9 checks passed
@StaehliJ StaehliJ deleted the 426-add-some-spaces-to-position-indicator branch February 20, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add some spaces to position indicator
2 participants
@StaehliJ @MGaetan89