Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore unknown video size #450

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Ignore unknown video size #450

merged 3 commits into from
Feb 23, 2024

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Feb 21, 2024 •
edited
Loading

Pull request

Description

The goal of this PR is to not reset the video aspect ratio when media transition to another. When loading video size is briefly set to unknown.

Changes made

  • Player.getAspectRatioAsFlow ignore unknown video size.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ self-assigned this Feb 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2024 •
edited
Loading

Code Coverage

Overall Project 45.93% -0.05% 🟢
Files changed 0% 🟢

Module Coverage
:pillarbox-player 62.52% -0.16% 🟢
Files
Module File Coverage
:pillarbox-player PlayerCallbackFlow.kt 72.58% -0.77% 🟢

@MGaetan89 MGaetan89 linked an issue Feb 21, 2024 that may be closed by this pull request
Smooth transition between media source #449
Closed
1 task
@StaehliJ StaehliJ added this pull request to the merge queue Feb 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 21, 2024
@StaehliJ StaehliJ added this pull request to the merge queue Feb 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 23, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Feb 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 23, 2024
@MGaetan89 MGaetan89 force-pushed the 449-smooth-transition-between-media-source branch from 96e39e5 to 4762d31 Compare February 23, 2024 16:29
@MGaetan89 MGaetan89 added this pull request to the merge queue Feb 23, 2024
Merged via the queue into main with commit 5a3355f Feb 23, 2024
9 checks passed
@MGaetan89 MGaetan89 deleted the 449-smooth-transition-between-media-source branch February 23, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Assignees

@StaehliJ StaehliJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Smooth transition between media source
2 participants
@StaehliJ @MGaetan89