-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor media loading #475
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f71a5b4.
Tag is used internally by PillarboxPlayer.
3 tasks
Code Coverage
Files
|
MGaetan89
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed some documentation/naming changes, otherwise, it looks good 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
The goal of this PR is to improve customizability when loading content with Pillarbox. This PR make also more clear where trackers data can be set or not.
AssetLoader
replaceMediaItemSource
, integrators have more control of how creating MediaSource, setting up MediaMetadata and trackers data.Loading SRG content
Loading Non SRG content
Custom content
For custom content, there is only one rule,
MediaItem.Builder.setUri
have to be called.For example it could be:
Changes made
MediaItemSource
replaced byAssetLoader
.MediaItem.tag
is removed when passed toPillarboxPlayer
as it is use for internally by trackers.Checklist
main
branch.