-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate last Android Tests to Unit Tests #477
Draft
MGaetan89
wants to merge
4
commits into
main
Choose a base branch
from
migrate_last_android_test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGaetan89
force-pushed
the
migrate_last_android_test
branch
4 times, most recently
from
April 8, 2024 09:41
f68a894
to
5c77be2
Compare
MGaetan89
force-pushed
the
migrate_last_android_test
branch
4 times, most recently
from
April 24, 2024 17:52
c679f09
to
4fff6bd
Compare
MGaetan89
force-pushed
the
migrate_last_android_test
branch
3 times, most recently
from
May 10, 2024 09:53
8081789
to
baee7cc
Compare
MGaetan89
force-pushed
the
migrate_last_android_test
branch
from
May 21, 2024 07:14
baee7cc
to
c5218a7
Compare
MGaetan89
force-pushed
the
migrate_last_android_test
branch
2 times, most recently
from
June 19, 2024 14:53
34cbc1b
to
83a10f1
Compare
MGaetan89
force-pushed
the
migrate_last_android_test
branch
2 times, most recently
from
July 2, 2024 07:40
f58eb65
to
535d6d9
Compare
MGaetan89
force-pushed
the
migrate_last_android_test
branch
3 times, most recently
from
July 18, 2024 06:44
8a7d830
to
24ba495
Compare
MGaetan89
force-pushed
the
migrate_last_android_test
branch
2 times, most recently
from
July 29, 2024 11:49
0cc820c
to
7d87a1a
Compare
MGaetan89
force-pushed
the
migrate_last_android_test
branch
from
July 31, 2024 07:00
7d87a1a
to
2063a86
Compare
MGaetan89
force-pushed
the
migrate_last_android_test
branch
from
August 21, 2024 18:53
2063a86
to
90bf6df
Compare
MGaetan89
force-pushed
the
migrate_last_android_test
branch
from
September 3, 2024 11:27
90bf6df
to
4b8310b
Compare
MGaetan89
force-pushed
the
migrate_last_android_test
branch
2 times, most recently
from
September 18, 2024 12:45
98fa2c9
to
36d0553
Compare
MGaetan89
force-pushed
the
migrate_last_android_test
branch
from
September 26, 2024 15:12
36d0553
to
dad7763
Compare
MGaetan89
force-pushed
the
migrate_last_android_test
branch
2 times, most recently
from
October 14, 2024 09:36
380956a
to
4e7e606
Compare
MGaetan89
force-pushed
the
migrate_last_android_test
branch
from
November 19, 2024 16:04
4e7e606
to
0b34559
Compare
MGaetan89
force-pushed
the
migrate_last_android_test
branch
from
December 17, 2024 09:28
0b34559
to
3e4f07a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This PR migrates the last Android Tests (in
IsPlayingAllTypeOfContentTest
) to regular Unit Tests.Note
In draft for now, because there is one case that is failing.
Changes made
IsPlayingAllTypeOfContentTest
to use Robolectric as a regular Unit TestDependency Analysis
step now displays the warnings, instead of uploading a zip fileChecklist
main
branch.