Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't filter out unsupported/forced tracks #487

Merged

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Apr 5, 2024

Pull request

Description

This PR fixes the selection of alternative audio/text/video tracks, when some tracks have been filtered out. When selecting an other track, Media3 checks that the provided group is a known one, thus we keep filter out some tracks.

Changes made

  • Remove filtering on audio/text/video tracks
  • Update demo apps to disable unsupported tracks
  • Update tests to include unsupported tracks

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Apr 5, 2024 that may be closed by this pull request
1 task
@MGaetan89 MGaetan89 self-assigned this Apr 5, 2024
Copy link

github-actions bot commented Apr 5, 2024

Code Coverage

Overall Project 55.25% 🟢
Module Coverage
:pillarbox-player 73.15% 🟢
Files
Module File Coverage
:pillarbox-player Tracks.kt 100% 🟢

@StaehliJ StaehliJ added this pull request to the merge queue Apr 5, 2024
Merged via the queue into main with commit e3b6906 Apr 5, 2024
10 checks passed
@StaehliJ StaehliJ deleted the 486-cant-change-audio-track-in-the-demo-with-a-pixel8 branch April 5, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Can't change Audio track in the Demo with a Pixel8
2 participants