Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve metrics collector #644

Merged
merged 10 commits into from
Jul 23, 2024
Merged

Improve metrics collector #644

merged 10 commits into from
Jul 23, 2024

Conversation

StaehliJ
Copy link
Contributor

Pull request

Description

The goal of this PR is to measure metric for each session for consistency.

Changes made

  • Self-Explanatory

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ added this to the QoS milestone Jul 19, 2024
Copy link

github-actions bot commented Jul 19, 2024

Code Coverage

Overall Project 53.5% -0.86% 🟢
Files changed 76.12% 🟢

Module Coverage
:pillarbox-player 59.26% -1.61% 🟢
Files
Module File Coverage
:pillarbox-player PlaybackMetrics.kt 97.39% -2.61% 🟢
SessionMetrics.kt 88.58% -11.42% 🟢
QoSCoordinator.kt 85.68% 🟢
MetricsCollector.kt 68.49% -30.31% 🟢

Copy link
Member

@MGaetan89 MGaetan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments/questions, but looks good otherwise.
From a quick testing, it seems to be working fine 👍🏻

@MGaetan89 MGaetan89 merged commit 809101b into qos Jul 23, 2024
10 checks passed
@MGaetan89 MGaetan89 deleted the improve-metrics-collector branch July 23, 2024 13:03
MGaetan89 added a commit that referenced this pull request Jul 29, 2024
MGaetan89 added a commit that referenced this pull request Jul 30, 2024
MGaetan89 added a commit that referenced this pull request Aug 12, 2024
MGaetan89 added a commit that referenced this pull request Aug 13, 2024
MGaetan89 added a commit that referenced this pull request Aug 20, 2024
StaehliJ added a commit that referenced this pull request Aug 28, 2024
StaehliJ added a commit that referenced this pull request Sep 11, 2024
MGaetan89 added a commit that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants