-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update models for QoS #654
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage
Files
|
…times (#596) Co-authored-by: Joaquim Stähli <[email protected]>
Co-authored-by: Gaëtan Muller <[email protected]>
Co-authored-by: Gaëtan Muller <[email protected]>
Co-authored-by: Gaëtan Muller <[email protected]> Co-authored-by: Gaëtan Muller <[email protected]>
Co-authored-by: Gaëtan Muller <[email protected]> Co-authored-by: Gaëtan Muller <[email protected]>
Co-authored-by: Gaëtan Muller <[email protected]>
MGaetan89
force-pushed
the
update_qos_models
branch
from
July 29, 2024 11:53
d3e6575
to
d6a0091
Compare
MGaetan89
force-pushed
the
update_qos_models
branch
from
July 29, 2024 13:03
d6a0091
to
467b57e
Compare
Co-authored-by: Gaëtan Muller <[email protected]>
MGaetan89
force-pushed
the
update_qos_models
branch
from
July 30, 2024 07:26
467b57e
to
1d90c3e
Compare
Co-authored-by: Joaquim Stähli <[email protected]>
StaehliJ
reviewed
Jul 30, 2024
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/qos/models/QoSSession.kt
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/qos/models/QoSSessionTimings.kt
Outdated
Show resolved
Hide resolved
MGaetan89
force-pushed
the
update_qos_models
branch
from
July 30, 2024 08:07
1d90c3e
to
aa4a8f9
Compare
StaehliJ
approved these changes
Jul 30, 2024
MGaetan89
added a commit
that referenced
this pull request
Aug 12, 2024
Co-authored-by: Joaquim Stähli <[email protected]>
MGaetan89
added a commit
that referenced
this pull request
Aug 13, 2024
Co-authored-by: Joaquim Stähli <[email protected]>
MGaetan89
added a commit
that referenced
this pull request
Aug 20, 2024
Co-authored-by: Joaquim Stähli <[email protected]>
StaehliJ
added a commit
that referenced
this pull request
Aug 28, 2024
Co-authored-by: Joaquim Stähli <[email protected]>
StaehliJ
added a commit
that referenced
this pull request
Sep 11, 2024
Co-authored-by: Joaquim Stähli <[email protected]>
MGaetan89
added a commit
that referenced
this pull request
Sep 12, 2024
Co-authored-by: Joaquim Stähli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
Following recent discussions, I've updated the models related to QoS.
Changes made
models
package.Context.getDeviceType()
extension inQoSSession
to supportDESKTOP
, and returnUNKNOWN
by default (instead ofPHONE
).Checklist
main
branch.