Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update models for QoS #654

Merged
merged 18 commits into from
Jul 30, 2024
Merged

Update models for QoS #654

merged 18 commits into from
Jul 30, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Jul 25, 2024

Pull request

Description

Following recent discussions, I've updated the models related to QoS.

Changes made

  • Update the existing models for QoS to match the latest agreement.
  • Move all QoS-related models into a dedicated models package.
  • Update the Context.getDeviceType() extension in QoSSession to support DESKTOP, and return UNKNOWN by default (instead of PHONE).

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 self-assigned this Jul 25, 2024
@MGaetan89 MGaetan89 added this to the QoS milestone Jul 25, 2024
Copy link

github-actions bot commented Jul 25, 2024

Code Coverage

Overall Project 53.98% -0.02% 🟢
Files changed 98.89% 🟢

Module Coverage
:pillarbox-player 60.25% -0.04% 🟢
Files
Module File Coverage
:pillarbox-player QoSMessageHandler.kt 100% 🟢
QoSEvent.kt 100% 🟢
QoSScreen.kt 100% 🟢
QoSSessionTimings.kt 100% 🟢
QoSMedia.kt 100% 🟢
QoSSession.kt 100% 🟢
QoSMessage.kt 100% 🟢
QoSOS.kt 100% 🟢
QoSPlayer.kt 100% 🟢
QoSDevice.kt 100% 🟢
QoSStall.kt 100% 🟢
QoSError.kt 97.18% -2.82% 🟢
QoSCoordinator.kt 86.01% -0.93% 🟢

Co-authored-by: Gaëtan Muller <[email protected]>
@StaehliJ StaehliJ merged commit 1b62395 into qos Jul 30, 2024
10 checks passed
@StaehliJ StaehliJ deleted the update_qos_models branch July 30, 2024 09:23
MGaetan89 added a commit that referenced this pull request Aug 12, 2024
Co-authored-by: Joaquim Stähli <[email protected]>
MGaetan89 added a commit that referenced this pull request Aug 13, 2024
Co-authored-by: Joaquim Stähli <[email protected]>
MGaetan89 added a commit that referenced this pull request Aug 20, 2024
Co-authored-by: Joaquim Stähli <[email protected]>
StaehliJ added a commit that referenced this pull request Aug 28, 2024
Co-authored-by: Joaquim Stähli <[email protected]>
StaehliJ added a commit that referenced this pull request Sep 11, 2024
Co-authored-by: Joaquim Stähli <[email protected]>
MGaetan89 added a commit that referenced this pull request Sep 12, 2024
Co-authored-by: Joaquim Stähli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants