Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update heartbeat behavior #656

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Update heartbeat behavior #656

merged 5 commits into from
Jul 30, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Jul 26, 2024

Description

This PR updates the behavior of the heartbeat to match what was decided in the last API sync.

Changes made

  • Change the heartbeat period to 30 seconds.
  • Keep the heartbeat active when the player is paused.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Jul 26, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jul 26, 2024

Code Coverage

Overall Project 53.21% -0.01% 🟢
Files changed 97.3% 🟢

Module Coverage
:pillarbox-core-business 81.95% 🟢
:pillarbox-player 59.07% -0.02% 🟢
Files
Module File Coverage
:pillarbox-core-business CommandersActStreaming.kt 95.31% 🟢
:pillarbox-player Heartbeat.kt 98.52% 🟢
QoSCoordinator.kt 86.22% 🟢
PillarboxExoPlayer.kt 80.61% -0.33% 🟢
PillarboxEventsDispatcher.kt 62.23% 🟢
QoSEventsDispatcher.kt 0% 🟢

@MGaetan89 MGaetan89 force-pushed the 653-update-the-heartbeat-logic branch 2 times, most recently from 8c1ad03 to f1ef9c6 Compare July 29, 2024 13:04
@StaehliJ StaehliJ force-pushed the 653-update-the-heartbeat-logic branch from 0ab6272 to 055de8c Compare July 30, 2024 07:26
@StaehliJ StaehliJ merged commit 4c8be12 into qos Jul 30, 2024
10 checks passed
@StaehliJ StaehliJ deleted the 653-update-the-heartbeat-logic branch July 30, 2024 08:00
MGaetan89 added a commit that referenced this pull request Jul 30, 2024
Co-authored-by: Joaquim Stähli <[email protected]>
MGaetan89 added a commit that referenced this pull request Aug 12, 2024
Co-authored-by: Joaquim Stähli <[email protected]>
MGaetan89 added a commit that referenced this pull request Aug 13, 2024
Co-authored-by: Joaquim Stähli <[email protected]>
MGaetan89 added a commit that referenced this pull request Aug 20, 2024
Co-authored-by: Joaquim Stähli <[email protected]>
StaehliJ added a commit that referenced this pull request Aug 28, 2024
Co-authored-by: Joaquim Stähli <[email protected]>
StaehliJ added a commit that referenced this pull request Sep 11, 2024
Co-authored-by: Joaquim Stähli <[email protected]>
MGaetan89 added a commit that referenced this pull request Sep 12, 2024
Co-authored-by: Joaquim Stähli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Update the heartbeat logic
2 participants