Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create mobile screen for QoS #670

Merged
merged 6 commits into from
Aug 12, 2024
Merged

Create mobile screen for QoS #670

merged 6 commits into from
Aug 12, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Aug 8, 2024 •
edited
Loading

Pull request

Description

This PR adds a new section in the player settings to display the collected metrics about the currently playing media.

Changes made

  • Created StatsForNerdsViewModel in pillarbox-demo-shared to share data between pillarbox-demo and pillarbox-demo-tv.
  • Created the StatsForNerds screens in pillarbox-demo and pillarbox-demo-tv.
  • Added a new entry in the player settings to access the metrics screen.
  • Added a new DemoListItemView variant, where the title and value are displayed on one line.
  • Improved DemoPlayerView landscape support when displaying the player settings.
  • Improved demo and Media3 versions display in the app settings.

Screenshots

Mobile screenshots

Description Screenshot
Player setting Screenshot_20240808_161205
Metrics view (info) Screenshot_20240808_161329
Metrics view (charts) Screenshot_20240808_161337
Player settings (landscape) Screenshot_20240808_161350
Metrics view (landscape) Screenshot_20240808_161357

TV screenshots

Description Screenshot
Player setting Screenshot_20240808_161829
Metrics view (info) Screenshot_20240808_165859
Metric view (charts) Screenshot_20240808_165943

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Aug 8, 2024 that may be closed by this pull request
Display metrics chart inside the demo #664
Closed
1 task
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 8, 2024
View reviewed changes
pillarbox-demo-shared/src/main/res/values/strings.xml Dismissed Show dismissed Hide dismissed
pillarbox-demo-shared/src/main/res/values/strings.xml Dismissed Show dismissed Hide dismissed
pillarbox-demo-shared/src/main/res/values/strings.xml Dismissed Show dismissed Hide dismissed
pillarbox-demo-shared/src/main/res/values/strings.xml Dismissed Show dismissed Hide dismissed
pillarbox-demo-shared/src/main/res/values/strings.xml Dismissed Show dismissed Hide dismissed
pillarbox-demo-shared/src/main/res/values/strings.xml Dismissed Show dismissed Hide dismissed
pillarbox-demo-shared/src/main/res/values/strings.xml Dismissed Show dismissed Hide dismissed
pillarbox-demo-shared/src/main/res/values/strings.xml Dismissed Show dismissed Hide dismissed
pillarbox-demo-shared/src/main/res/values/strings.xml Dismissed Show dismissed Hide dismissed
pillarbox-demo-shared/src/main/res/values/strings.xml Dismissed Show dismissed Hide dismissed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

Code Coverage

Overall Project 53.46% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 force-pushed the 664-display-metrics-chart-inside-the-demo branch from cca67a2 to d61245b Compare August 9, 2024 13:59
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 9, 2024
View reviewed changes
pillarbox-demo-tv/src/main/java/ch/srgssr/pillarbox/demo/tv/ui/player/metrics/StatsForNerds.kt Fixed Show fixed Hide fixed
pillarbox-demo-tv/src/main/java/ch/srgssr/pillarbox/demo/tv/ui/player/metrics/StatsForNerds.kt Fixed Show fixed Hide fixed
pillarbox-demo-tv/src/main/java/ch/srgssr/pillarbox/demo/tv/ui/player/metrics/StatsForNerds.kt Fixed Show fixed Hide fixed
pillarbox-demo-tv/src/main/java/ch/srgssr/pillarbox/demo/tv/ui/player/metrics/StatsForNerds.kt Fixed Show fixed Hide fixed
pillarbox-demo/src/main/java/ch/srgssr/pillarbox/demo/ui/player/metrics/StatsForNerds.kt Fixed Show fixed Hide fixed
pillarbox-demo/src/main/java/ch/srgssr/pillarbox/demo/ui/player/metrics/StatsForNerds.kt Fixed Show fixed Hide fixed
@MGaetan89 MGaetan89 marked this pull request as ready for review August 9, 2024 14:35
@MGaetan89 MGaetan89 force-pushed the 664-display-metrics-chart-inside-the-demo branch from 7465df6 to e64536d Compare August 12, 2024 12:27
@StaehliJ StaehliJ merged commit 5e3b275 into qos Aug 12, 2024
10 checks passed
@StaehliJ StaehliJ deleted the 664-display-metrics-chart-inside-the-demo branch August 12, 2024 14:34
MGaetan89 added a commit that referenced this pull request Aug 12, 2024
@MGaetan89
Create mobile screen for QoS (#670)
44590af
MGaetan89 added a commit that referenced this pull request Aug 13, 2024
@MGaetan89
Create mobile screen for QoS (#670)
c11d1be
MGaetan89 added a commit that referenced this pull request Aug 20, 2024
@MGaetan89
Create mobile screen for QoS (#670)
f6812b1
StaehliJ pushed a commit that referenced this pull request Aug 28, 2024
@MGaetan89 @StaehliJ
Create mobile screen for QoS (#670)
e0bb884
StaehliJ pushed a commit that referenced this pull request Sep 11, 2024
@MGaetan89 @StaehliJ
Create mobile screen for QoS (#670)
3fe4852
MGaetan89 added a commit that referenced this pull request Sep 12, 2024
@MGaetan89
Create mobile screen for QoS (#670)
f587721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display metrics chart inside the demo
2 participants
@MGaetan89 @StaehliJ