Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to AndroidX Core 1.15.0 #783

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Nov 4, 2024

Pull request

Description

In #781, we received an update for AndroidX Core to use version 1.15.0. This version requires compile SDK to be 35 or newer.
This PR performs the update and performs the necessary code changes.

Changes made

  • Update to AndroidX Core 1.15.0.
  • Bump the compile SDK version to 35.
  • Fix retrieval of the app version name for ComScore. That field can be null now, in which case we use an empty string.
  • Fix some code documentation.
  • Remove deprecated code in pillarbox-demo-cast. This is no longer necessary since Enable edge-to-edge in the demo application #658.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 added the dependencies Pull requests that update a dependency file label Nov 4, 2024
@MGaetan89 MGaetan89 self-assigned this Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

Code Coverage

Overall Project 47.8% 🟢
Files changed 100% 🟢

Module Coverage
:pillarbox-analytics 88.04% 🟢
Kover Gradle Plugin XML report for :plugins 7.46% 🟢
Files
Module File Coverage
:pillarbox-analytics ComScoreSrg.kt 90.5% 🟢
Kover Gradle Plugin XML report for :plugins AppConfig.kt 0% 🟢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Status: 🍿 Code Review
Development

Successfully merging this pull request may close these issues.

1 participant