-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLAYRTS-5590 Update Highlight Cell Design #504
base: main
Are you sure you want to change the base?
Conversation
Did you also change highlight's dimensions ? ( mobile 200, tablet portrait 280, and tablet landscape 480) |
@pradie-charlotte |
@mutaben But if the UX team proposes a third one compatible with Apple rotation and size classes, this iPad may could do this:
If the Android test on tablet is validated, let check on iPad then. |
Hello @mutaben @pyby , As explained by @pradie-charlotte, we have these height for the highlight, as defined in the Figma:
We Asked Alessandra if for the tablet land 480 was too much. But since she's on holiday, we decided to merge, and update the height later if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure VerticalGradientView(midwayStop: 0.3)
or the VerticalGradientView
height is enough for light background images.
Nice stops improvement.
Co-authored-by: Pierre-Yves <[email protected]>
Description
Up until now, there was a linear gradient on Highlight Cells, helping make the text more legible.
This PR improves this aspect based on UI/UX requirements, by improving legibility without darkening the highlighted content too much.
In the following images, you can see the raw gradients, how they used to be and how they were implemented after various attempts to find the best result.
Please see also some screenshots to see it in action today.
Changes Made
This was implemented by:
The gradients were tweaked for large and compact size, and for different amount of text content. (see the raw gradients above)
If they need to be adjusted in the future, they now have their own view and the midway point to stop the gradient is customizable as a parameter.
Checklist