Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add rule to favicon optimisation #6183

Merged
merged 13 commits into from
Aug 7, 2023
Merged

✨ Add rule to favicon optimisation #6183

merged 13 commits into from
Aug 7, 2023

Conversation

jackreimers
Copy link
Contributor

No description provided.

rules/optimise-your-favicon/rule.md Outdated Show resolved Hide resolved
-
---

Favicons are commonplace in web development, but did you know your favicon may not be properly optimised for all devices?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer answering the question (rule title) in the intro, and then going into more detail after

@UlyssesMaclaren UlyssesMaclaren enabled auto-merge (squash) August 1, 2023 00:21
Copy link
Contributor

@Hona Hona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshots I would 150% zoom & exclude random browser UI

@jackreimers jackreimers requested a review from Hona August 4, 2023 06:20
@bradystroud
Copy link
Member

bradystroud commented Aug 7, 2023

The images you want to use haven't been uploaded

@bradystroud
Copy link
Member

The images you want to use haven't been uploaded

Fixed

rules/optimise-your-favicon/rule.md Outdated Show resolved Hide resolved
rules/optimise-your-favicon/rule.md Outdated Show resolved Hide resolved
@UlyssesMaclaren UlyssesMaclaren merged commit 837e98b into SSWConsulting:main Aug 7, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants