Create Rule “optimise-js-with-lodash/rule” #6223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackDevAU
requested review from
wicksipedia,
danielmackay,
bradystroud and
duanxinhuan
bradystroud
requested changes
Aug 2, 2023
JackDevAU
commented
Aug 2, 2023
JackDevAU
force-pushed
the
cms/JackDevAU/SSW.Rules.Content/rule/optimise-js-with-lodash/rule
branch
from
25cf39c
to
e817ed8
Compare
bradystroud
requested changes
Aug 3, 2023
There was a problem hiding this comment.
cc @christoment
lodash is massive, you should cherry pick what functions you are importing.
Can you update the rule to add this performance tip?
JackDevAU
commented
Aug 3, 2023
bradystroud
approved these changes
Aug 3, 2023
JackDevAU
deleted the
cms/JackDevAU/SSW.Rules.Content/rule/optimise-js-with-lodash/rule
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically generated by Netlify CMS