Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NextJS setup #6724

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Update NextJS setup #6724

merged 2 commits into from
Sep 18, 2023

Conversation

tino-liu
Copy link
Member

Update NextJS setup using the latest official NextJS docs

@tino-liu
Update NextJS setup
87e5fc6 
Update NextJS setup using the latest official NextJS docs
@github-actions github-actions bot added Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old labels Sep 14, 2023
christoment
christoment reviewed Sep 14, 2023
View reviewed changes
rules/how-to-easily-start-a-react-project/rule.md Outdated
Comment on lines 68 to 76
What is your project named? my-app
Would you like to use TypeScript? No / Yes
Would you like to use ESLint? No / Yes
Would you like to use Tailwind CSS? No / Yes
Would you like to use `src/` directory? No / Yes
Would you like to use App Router? (recommended) No / Yes
Would you like to customize the default import alias? No / Yes
```
**Note:** Prompts are subject to change depending on NextJS versions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I'd leave out the prompt example here since they can get deprecated real quickly 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done and removed 😆

@github-actions github-actions bot added Age: 🐓 - Old About 32 hours old Age: 🍗 - Ancient About 64 hours old Age: 🦖 - Extinct About 128 hours old and removed Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old Age: 🍗 - Ancient About 64 hours old labels Sep 15, 2023
Harry-Ross
Harry-Ross approved these changes Sep 17, 2023
View reviewed changes
Copy link
Contributor

@Harry-Ross Harry-Ross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🛥️

@tino-liu tino-liu merged commit fbdc3b4 into SSWConsulting:main Sep 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christoment christoment christoment approved these changes

@Harry-Ross Harry-Ross Harry-Ross approved these changes

@Aibono1225 Aibono1225 Awaiting requested review from Aibono1225

Assignees
No one assigned
Labels
Age: 🦖 - Extinct About 128 hours old
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tino-liu @Harry-Ross @christoment