Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving the warning around linking issues and adding more context #6856

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Moving the warning around linking issues and adding more context #6856

merged 1 commit into from
Sep 27, 2023

Conversation

GordonBeeming
Copy link
Member

@GordonBeeming GordonBeeming commented Sep 27, 2023 •
edited
Loading

Reason for change (Issue, Email, conversation + reason, etc)

Based on email thread, subject: RE: Pull Requests - Writing good PR bodies

In the last section about linking the issue I think the warning should be at/near the start of the section so it’s harder to miss.
Might also be worth mentioning that certain keywords in the PR description can cause the issue to be linked and closed (i.e. resolves, closes)

image

jackreimers
jackreimers approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@jackreimers jackreimers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@GordonBeeming GordonBeeming merged commit 920a4c1 into SSWConsulting:main Sep 27, 2023
5 of 6 checks passed
@GordonBeeming GordonBeeming deleted the write-a-good-pull-request-2 branch September 27, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackreimers jackreimers jackreimers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GordonBeeming @jackreimers