Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XS✔ ◾ fix protect-your-master-branch #6879

Merged
merged 3 commits into from
Oct 3, 2023
Merged

XS✔ ◾ fix protect-your-master-branch #6879

merged 3 commits into from
Oct 3, 2023

Conversation

JackDevAU
Copy link
Member

@JackDevAU JackDevAU commented Oct 3, 2023 •
edited
Loading

Fix Rule: protect-your-master-branch

Hey @tiagov8

This should fix the rule https://ssw.com.au/rules/protect-your-master-branch

  • renamed folder to match the current URI
  • Added old URI to redirects
  • Find and update rule uri in categories

@github-actions github-actions bot changed the title fix protect-your-master-branch XS✔ ◾ fix protect-your-master-branch Oct 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023 •
edited
Loading

PR Metrics

✔ Thanks for keeping your pull request small.
✔ Thanks for adding tests.

Lines
Product Code 0
Test Code 0
Subtotal 0
Ignored Code 11
Total 11

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Oct 3, 2023
@JackDevAU
Copy link
Member Author

Hey @wicksipedia

Noticed the category and folder name weren't updated when you revised the rule.
FYI - For next time, here's the guideline: https://github.com/SSWConsulting/SSW.Rules.Content/wiki/How-to-Rename-Rules

@JackDevAU JackDevAU added the rubber stamp No thorough review required label Oct 3, 2023
@tiagov8 tiagov8 merged commit 24de242 into main Oct 3, 2023
4 checks passed
@tiagov8 tiagov8 deleted the fix-protect-your-master-branch branch October 3, 2023 02:42
@JackDevAU JackDevAU restored the fix-protect-your-master-branch branch October 3, 2023 05:25
@JackDevAU JackDevAU deleted the fix-protect-your-master-branch branch October 4, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagov8 tiagov8 tiagov8 approved these changes

@bradystroud bradystroud Awaiting requested review from bradystroud

Assignees
No one assigned
Labels
Age: 🥚 - New About 2 hours old rubber stamp No thorough review required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JackDevAU @tiagov8