Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/52706 update problem details rule #6883

Conversation

christoment
Copy link
Contributor

As per task in TimePro board Product Backlog Item 52680: ⚖️ SSW Rule | Rule on error handling on frontend

this PR updates the rule to detailed error message with ProblemDetails in modern .NET

  • Added ProblemDetails specification
  • Added options on how to return ProblemDetails in .NET

Copy link
Contributor

@matt-goldman matt-goldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement to the rule! Some minor tweaks suggested.

rules/do-you-return-detailed-error-messages/rule.md Outdated Show resolved Hide resolved
rules/do-you-return-detailed-error-messages/rule.md Outdated Show resolved Hide resolved
rules/do-you-return-detailed-error-messages/rule.md Outdated Show resolved Hide resolved
rules/do-you-return-detailed-error-messages/rule.md Outdated Show resolved Hide resolved
Copy link
Contributor

@matt-goldman matt-goldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions github-actions bot added Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old labels Oct 3, 2023
@matt-goldman matt-goldman merged commit 9b83495 into SSWConsulting:main Oct 3, 2023
4 checks passed
@christoment christoment deleted the features/52706-update-problem-details-rule branch October 3, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🐓 - Old About 32 hours old
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants