Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ Updating the blurb for clean architecture rules category #7121

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

GordonBeeming
Copy link
Member

@GordonBeeming GordonBeeming commented Oct 30, 2023

Reason for change (Issue, Email, conversation + reason, etc)

As per my conversation with Adam, the intro to the Clean Architecture category needed to be reworded a little

Done with @adamcogan

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Oct 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code 0
Test Code 0
Subtotal 0
Ignored Code 2
Total 2

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Updating the blurb for clean architecture rules category XS✔ ◾ Updating the blurb for clean architecture rules category Oct 30, 2023
@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old labels Oct 30, 2023
Copy link
Member

@tiagov8 tiagov8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @GordonBeeming

  • 1. Add full stop in the updated sentece
  • 2. Update the link to software audit page (it's still aspx)
  • 3. Link - Change from "our Software Auditing page" to "SSW's Software Audit consulting page"

@github-actions github-actions bot added Age: 🐓 - Old About 32 hours old and removed Age: 🐤 - Mature About 16 hours old labels Oct 30, 2023
@GordonBeeming GordonBeeming enabled auto-merge (squash) October 31, 2023 00:12
@github-actions github-actions bot added Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ and removed Age: 🐓 - Old About 32 hours old labels Oct 31, 2023
@github-actions
Copy link
Contributor

Howzit @GordonBeeming,

This PR has been here a while.

Did you know you should avoid merge debt?

Please review and merge or close.

Thanks!

@GordonBeeming GordonBeeming merged commit 5bb8502 into main Nov 1, 2023
4 checks passed
@GordonBeeming GordonBeeming deleted the clean-architecture-1 branch November 1, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants