Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XS✔ ◾ Create rule for Teams. md #7134

Merged
merged 10 commits into from
Nov 1, 2023
Merged

XS✔ ◾ Create rule for Teams. md #7134

merged 10 commits into from
Nov 1, 2023

Conversation

ae-cher-ssw
Copy link
Contributor

Request for Uly to review draft rule

@ae-cher-ssw
Create rule for Teams. md
9ea4100 
Request for Uly to review
@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Oct 31, 2023
@github-actions
Copy link
Contributor

Hi @ae-cher-ssw,
Invalid Frontmatter detected in rules/connect-client-im/rule.md, please fix the following issues:

  1. must have required property 'guid'
  2. must have required property 'uri'
  3. must have required property 'created'
  4. 'authors' must be valid content.

Please fix the Frontmatter in your Markdown files.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2023 •
edited
Loading

PR Metrics

✔ Thanks for keeping your pull request small.
✔ Thanks for adding tests.

Lines
Product Code 0
Test Code 0
Subtotal 0
Ignored Code 68
Total 68

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Create rule for Teams. md XS✔ ◾ Create rule for Teams. md Oct 31, 2023
@github-actions
Copy link
Contributor

Hi @ae-cher-ssw,
Invalid Frontmatter detected in rules/connect-client-im/rule.md, please fix the following issues:

  1. must have required property 'guid'
  2. must have required property 'created'
  3. 'authors' must be valid content.

Please fix the Frontmatter in your Markdown files.

@sethdaily
Copy link
Member

sethdaily commented Oct 31, 2023 •
edited
Loading

@ae-cher-ssw

You're missing these fields in your rule:

URL: put your people profile under your name
related: any related rules
created: put today's date, in the format in the screenshot
guid: get a randomly generated one from guidgen.com

image
Figure: Include these

ae-cher-ssw
ae-cher-ssw commented Oct 31, 2023
View reviewed changes
Copy link
Contributor Author

@ae-cher-ssw ae-cher-ssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help Seth!

@github-actions
Copy link
Contributor

Hi @ae-cher-ssw,
Invalid Frontmatter detected in rules/connect-client-im/rule.md, please fix the following issues:

  1. 'authors' must be valid content.

Please fix the Frontmatter in your Markdown files.

sethdaily
sethdaily reviewed Oct 31, 2023
View reviewed changes
rules/connect-client-im/rule.md Outdated

In other words, Microsoft Teams = buddies :-)

## Microsoft Teams Context
Copy link
Member

@sethdaily sethdaily Oct 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Microsoft Teams Context
## Teams Context

'Microsoft' Teams is already mentioned before so might be ok to just say Teams

@github-actions
Copy link
Contributor

Hi @ae-cher-ssw,
Invalid Frontmatter detected in rules/connect-client-im/rule.md, please fix the following issues:

  1. 'authors' must be valid content.

Please fix the Frontmatter in your Markdown files.

@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old labels Oct 31, 2023
@github-actions github-actions bot added Age: 🐓 - Old About 32 hours old Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ and removed Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old labels Oct 31, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023

Howzit @ae-cher-ssw,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

@UlyssesMaclaren UlyssesMaclaren marked this pull request as ready for review November 1, 2023 22:01
@UlyssesMaclaren UlyssesMaclaren merged commit 1339cb2 into main Nov 1, 2023
6 checks passed
@UlyssesMaclaren UlyssesMaclaren deleted the ae-cher-ssw-patch-1 branch November 1, 2023 22:01
@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethdaily sethdaily sethdaily left review comments

@UlyssesMaclaren UlyssesMaclaren UlyssesMaclaren approved these changes

Assignees
No one assigned
Labels
Age: 🍗 - Ancient About 64 hours old Age: 🥚 - New About 2 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ae-cher-ssw @sethdaily @UlyssesMaclaren