Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XS✔ ◾ 🧠⚡️ Brainstorming improvements #7140

Merged
merged 7 commits into from
Nov 6, 2023
Merged

XS✔ ◾ 🧠⚡️ Brainstorming improvements #7140

merged 7 commits into from
Nov 6, 2023

Conversation

bradystroud
Copy link
Member

@bradystroud bradystroud commented Oct 31, 2023 •
edited
Loading

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Reviewing the rules with @william-liebenberg

  1. What was changed?

Adding missing content
Improvements

  1. Did you do pair or mob programming?

No

@bradystroud bradystroud marked this pull request as draft October 31, 2023 07:09
@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Oct 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2023 •
edited
Loading

PR Metrics

✔ Thanks for keeping your pull request small.
✔ Thanks for adding tests.

Lines
Product Code 0
Test Code 0
Subtotal 0
Ignored Code 38
Total 38

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title 🧠⚡️ Brainstorming improvements XS✔ ◾ 🧠⚡️ Brainstorming improvements Oct 31, 2023
@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old labels Oct 31, 2023
@github-actions github-actions bot added Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ and removed Age: 🐓 - Old About 32 hours old labels Nov 1, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023

Howzit @bradystroud,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

@github-actions github-actions bot added Age: 🦖 - Extinct About 128 hours old and removed Age: 🍗 - Ancient About 64 hours old labels Nov 3, 2023
@bradystroud bradystroud marked this pull request as ready for review November 6, 2023 22:44
@bradystroud bradystroud merged commit b4fa5ba into main Nov 6, 2023
6 checks passed
@bradystroud bradystroud deleted the bradystroud-patch-3 branch November 6, 2023 22:44
@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaydenalchin jaydenalchin jaydenalchin approved these changes

Assignees
No one assigned
Labels
Age: 🦖 - Extinct About 128 hours old Age: 🥚 - New About 2 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bradystroud @jaydenalchin