Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ use diff characters to fix frontmatter issue #7142

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

JackDevAU
Copy link
Member

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Prod build broken

  1. What was changed?

From

-

To

  1. Did you do pair or mob programming?

I worked with @BrookJeynes

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Nov 1, 2023
Copy link
Contributor

github-actions bot commented Nov 1, 2023

Hi @JackDevAU,
Invalid Frontmatter detected in rules/do-you-know-the-best-practices-for-frontmatter-in-markdown/rule.md: missing '---'

Please fix the Frontmatter in your Markdown files.

Copy link
Contributor

github-actions bot commented Nov 1, 2023

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code 0
Test Code 0
Subtotal 0
Ignored Code 8
Total 8

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title use diff characters to fix frontmatter issue XS✔ ◾ use diff characters to fix frontmatter issue Nov 1, 2023
Copy link
Member

@bradystroud bradystroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the actual difference?
I think you are using a slightly different character.

This is very hard to spot, we should document it well

@JackDevAU
Copy link
Member Author

JackDevAU commented Nov 1, 2023

@bradystroud

There can only be 1 set of frontmatter in a markdown file.

To Myself,

  • 1. Add a rule in the GitHub validator to check for multiple sets of frontmatter blocks

In this rule (about frontmatter) we are using the --- frontmatter symbols multiple times. Which is causing the error. To fix this we are using a Greek character that looks exactly the same instead. (See below chi character)

image
Figure Greek chi character being used

@JackDevAU JackDevAU enabled auto-merge (squash) November 1, 2023 01:44
@JackDevAU JackDevAU merged commit ccb5046 into main Nov 1, 2023
4 checks passed
@JackDevAU JackDevAU deleted the fix-frontmatter-sadface branch November 1, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🥚 - New About 2 hours old
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants